jaredhanson / jaredhanson/deamdify

including global plugin imgAreaSelect breaks deamdify-ed modules which requires it

Open
#41 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
196
Forks
29
PR merge metrics
No merged PRs in 30d

Description

If a module contains the line:

```
require('...path.../imgareaselect/jquery.imgareaselect.js');
```

which is this file:
https://github.com/odyniec/imgareaselect/blob/new/jquery.imgareaselect.js

Then the transformed bundle will have the module's code messed up. Comments and new lines are removed, and even some brackets are removed.

For example:

```
config.screenshotareaselect.setOptions({
x1: x - (width / 2),
x2: x + (width / 2),
y1: y - (height / 2),
y2: y + (height / 2),
```

becames

```
config.screenshotareaselect.setOptions({
x1: x - width / 2,
x2: x + width / 2,
y1: y - height / 2,
y2: y + height / 2,
```

Contributor guide

No contributing guide indexed for this repository

Research direction

Reproduce the transformation with a module requiring jquery.imgareaselect.js, then compare the transformed bundle with the source example in the report. Trace how that dependency is parsed and transformed; done means the module's comments, newlines, brackets, and arithmetic grouping are preserved in the generated bundle.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
tooling
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.