`Path.open()` signature differs from pathlib, open() builtin
Open
Beginner friendly
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 67
- Forks
- 68
- PR merge metrics
- No merged PRs in 30d
Description
If I call zipp.Path.open('r', 1), the last argument is interpreted as an encoding argument, whereas in pathlib.Path.open('r', 1) and open('foo', 'r', 1) the last argument is interpreted as a buffering argument.
Could the signature be adjusted to match pathlib and io? Thank you
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at the zipp.Path.open() entry point and compare its argument handling with pathlib.Path.open() and the open() builtin. Verify that the positional argument after mode is treated as buffering rather than encoding, and add or update coverage so the matching behavior is clear.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- tooling
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 65/100