jaraco / jaraco/skeleton

Enable strict and disable "ignore missing imports" where viable

Open
#117 3 comments 0 reactions 0 assignees View on GitHub
Dominant language
No language data
Stars
150
Forks
38
Avg merge
1m
Merged PRs (30d)
1

Description

one-size-fits-all seems to me to be a strange goal for mypy configuration. Different projects will have different imports: some of which will have complete type stubs, some of which will have partial type stubs, some of which will have none.

I would recommend that you go strict everywhere, and ignore missing imports explicitly for specific packages as needed, rather than unconditionally ignore-missing-imports. That makes it clearer what is going on and - as here, perhaps! - encourages contributions to dependencies that are nearly well-typed.

_Originally posted by @dimbleby in https://github.com/jaraco/jaraco.classes/pull/13#discussion_r1544981101_

Contributor guide

No contributing guide indexed for this repository

Research direction

Start by locating the project's mypy configuration and reviewing how ignore-missing-imports is currently applied. Enable strict checking where viable, then record explicit exceptions for packages that need them; done means the configuration is no longer unconditionally ignoring missing imports and the project checks still pass.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
tooling
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.