Windows requires username passed to get_credential
Open
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 1.5k
- Forks
- 196
- PR merge metrics
- No merged PRs in 30d
Description
In https://github.com/jaraco/keyring/issues/668#issuecomment-2274273778, I learned that the `WinVaultKeyring.get_credential` doesn't honor the default `username=None` as indicated by the base class. It should.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Search for WinVaultKeyring.get_credential and compare its signature and behavior with the base class, especially the default username=None. Confirm that omitting the username is accepted as described; add or update the relevant test if one is present nearby, then run the keyring test suite to verify the Windows behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- security
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100