janestreet / janestreet/torch

HEAD doesn't compile; commit 4c203374a9a3d977bee94d68fc802ecceac0eb4c (HEAD -> master, origin/master, origin/HEAD)

Open
#21 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

forwarded-to-js-devs
Dominant language
OCaml
Stars
162
Forks
14
PR merge metrics
No merged PRs in 30d

Description

```bash
# make
dune build
File "src/wrapper/dune", line 20, characters 49-68:
20 | (libraries ctypes.foreign ctypes torch_bindings torch_wrapper_types)
^^^^^^^^^^^^^^^^^^^
Error: Library "torch_wrapper_types" is private, it cannot be a dependency of
a public library. You need to give "torch_wrapper_types" a public name.
File "src/torch_refcounted/dune", line 4, characters 28-49:
4 | (libraries base core stdio torch_local_iterators torch_refcounted_core unix)
^^^^^^^^^^^^^^^^^^^^^
Error: Library "torch_local_iterators" is private, it cannot be a dependency
of a public library. You need to give "torch_local_iterators" a public name.
File "src/wrapper_refcounted/dune", line 22, characters 29-48:
22 | torch_refcounted_bindings torch_wrapper_types)
^^^^^^^^^^^^^^^^^^^
Error: Library "torch_wrapper_types" is private, it cannot be a dependency of
a public library. You need to give "torch_wrapper_types" a public name.
File "src/wrapper_refcounted/dune", line 17, characters 21-53:
17 | (names torch_stubs torch_refcounted_stubs_generated)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Error: No rule found for
src/wrapper_refcounted/torch_refcounted_api_generated.h
File "src/wrapper_refcounted/dune", line 17, characters 21-53:
17 | (names torch_stubs torch_refcounted_stubs_generated)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Error: No rule found for
src/wrapper_refcounted/torch_refcounted_api_generated.cpp
File "src/diff_for_review/dune", line 56, characters 5-30:
56 | "%{bin:patdiff-for-review} %{bin:patdiff} %{deps} -context 2 > %{targets}")))
^^^^^^^^^^^^^^^^^^^^^^^^^
Error: Program patdiff-for-review not found in the tree or in PATH
(context: default)
File "src/diff_for_review/dune", line 21, characters 5-30:
21 | "%{bin:patdiff-for-review} %{bin:patdiff} %{deps} -context 2 > %{targets}")))
^^^^^^^^^^^^^^^^^^^^^^^^^
Error: Program patdiff-for-review not found in the tree or in PATH
(context: default)
File "src/diff_for_review/dune", line 28, characters 5-30:
28 | "%{bin:patdiff-for-review} %{bin:patdiff} %{deps} -context 2 > %{targets}")))
^^^^^^^^^^^^^^^^^^^^^^^^^
Error: Program patdiff-for-review not found in the tree or in PATH
(context: default)
File "src/diff_for_review/dune", line 14, characters 5-30:
14 | "%{bin:patdiff-for-review} %{bin:patdiff} %{deps} -context 2 > %{targets}")))
^^^^^^^^^^^^^^^^^^^^^^^^^
Error: Program patdiff-for-review not found in the tree or in PATH
(context: default)
File "src/diff_for_review/dune", line 35, characters 5-30:
35 | "%{bin:patdiff-for-review} %{bin:patdiff} %{deps} -context 2 > %{targets}")))
^^^^^^^^^^^^^^^^^^^^^^^^^
Error: Program patdiff-for-review not found in the tree or in PATH
(context: default)
File "src/diff_for_review/dune", line 42, characters 5-30:
42 | "%{bin:patdiff-for-review} %{bin:patdiff} %{deps} -context 2 > %{targets}")))
^^^^^^^^^^^^^^^^^^^^^^^^^
Error: Program patdiff-for-review not found in the tree or in PATH
(context: default)
File "src/diff_for_review/dune", line 49, characters 5-30:
49 | "%{bin:patdiff-for-review} %{bin:patdiff} %{deps} -context 2 > %{targets}")))
^^^^^^^^^^^^^^^^^^^^^^^^^
Error: Program patdiff-for-review not found in the tree or in PATH
(context: default)
File "src/local_iterators/list.ml", line 4, characters 2-26:
4 | List.fold__local__global list ~init:() ~f:(fun () x -> f x)
^^^^^^^^^^^^^^^^^^^^^^^^
Error: Unbound value List.fold__local__global
File "src/bindings_refcounted/torch_refcounted_bindings.ml", line 341, characters 21-58:
341 | module Generated = Torch_refcounted_bindings_generated.C (F)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Error: Unbound module Torch_refcounted_bindings_generated
make: *** [Makefile:4: default] Error 1
```

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by running `make` and inspect the reported failures in the listed `src/*/dune` files, `src/local_iterators/list.ml`, and `src/bindings_refcounted/torch_refcounted_bindings.ml`. Trace the private library dependencies, missing generated files, unavailable patdiff executable, and unbound OCaml values or modules. Done means `dune build` completes successfully.

Written by the indexing model from the issue text.

Assessment

Tech stack
ocaml
Domain
build-system
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.