janestreet / janestreet/ppx_embed_file

File path should be resolved relative to the source files path

Open
#1 1 comment 0 reactions 0 assignees View on GitHub
forwarded-to-js-devs
Dominant language
OCaml
Stars
2
Forks
1
PR merge metrics
No merged PRs in 30d

Description

As far as I can tell, currently, the path of the file to be embedded is resolved relative to the compilation root. This doesn't work when the project is in a subfolder of a bigger project, since the root changes. This would be fixed if the file path is always resolved relative to the source file, making it dune root-independent

Contributor guide

Open the contributing guide

Research direction

Start by tracing the PPX's file-embedding path resolution and how it obtains the compilation root versus the source file location. Verify the behavior when the project is in a subfolder of a larger project. Done means embedded file paths resolve relative to the source file and remain independent of the dune root.

Written by the indexing model from the issue text.

Assessment

Tech stack
ocaml
Domain
build-system, compilers
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Active
Clarity
Mostly clear
Newbie friendliness
68/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.