janestreet / janestreet/jsonaf

Stack overflow with large json files

Open
#2 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

forwarded-to-js-devs
Dominant language
OCaml
Stars
20
Forks
7
PR merge metrics
No merged PRs in 30d

Description

Recently I experimented with this library as both a native compilation target, as well as through jsoo, and on the jsoo side, I hit a stack overflow when running the code in the browser. I was able to get around the problem by converting the data file to sexp, but I figured I'd report the issue anyways.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the stack overflow with a large JSON file in the jsoo browser environment described in the issue, and compare it with the reported sexp workaround. The payload names no source files, tests, parser entry point, or concrete input, so those would need to be located before implementation. Done means the large-file case no longer overflows the stack in the affected environment, with a regression test if the project provides a suitable test location.

Written by the indexing model from the issue text.

Assessment

Tech stack
ocaml
Domain
data
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.