janestreet / janestreet/bonsai_web_components

Some bonsai_web_component libraries are missing public_name

Open Beginner friendly
#1 0 comments 0 reactions 0 assignees View on GitHub
forwarded-to-js-devs
Dominant language
OCaml
Stars
8
Forks
4
PR merge metrics
No merged PRs in 30d

Description

As far as I understand, without `public_name`, the libraries won't be installed.

examples of libraries missing `public_name`:
- https://github.com/janestreet/bonsai_web_components/blob/f87534894c3bb08c751eedc837c0bfdf2472ee1d/notifications/src/dune
- https://github.com/janestreet/bonsai_web_components/blob/f87534894c3bb08c751eedc837c0bfdf2472ee1d/not_connected_warning_box/src/dune

example of libraries having `public_name`:
- https://github.com/janestreet/bonsai_web_components/blob/f87534894c3bb08c751eedc837c0bfdf2472ee1d/drag_and_drop/src/dune

Contributor guide

Open the contributing guide

Research direction

Compare notifications/src/dune and not_connected_warning_box/src/dune with drag_and_drop/src/dune, focusing on how the public_name field is declared. Check the repository's Dune package and installation conventions before updating the two missing declarations. Done means the affected libraries have appropriate public_name values and are included when the project is installed.

Written by the indexing model from the issue text.

Assessment

Tech stack
ocaml
Domain
build-system
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Active
Clarity
Mostly clear
Newbie friendliness
78/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.