janestreet / janestreet/async_rpc_kernel

Monitor.* without ~here:[%here] or ~info

Open
#2 2 comments 0 reactions 0 assignees View on GitHub
forwarded-to-js-devs
Dominant language
OCaml
Stars
8
Forks
5
PR merge metrics
No merged PRs in 30d

Description

In this library all the use of `Monitor.protect`, `Monitor.try_with` have no location information. So it makes debugging a little tedious when you have an exception catched after the return of the function.

Expected behavior: At least know the name of the function called. But indeed without proper backtrace I will not know the call point in my code, so this lack of information is perhaps not the real issue.

Contributor guide

Open the contributing guide

Research direction

Start by locating the library uses of Monitor.protect and Monitor.try_with, then compare them with the location-aware ~here:[%here] or ~info forms mentioned in the issue. Done means exceptions caught after a function returns provide at least the called function's name or other useful location information.

Written by the indexing model from the issue text.

Assessment

Tech stack
ocaml
Domain
backend-api-design
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.