janeczku / janeczku/docker-dropbox
Add conditional check for current user:group id on run file.
Nobody has claimed this yet.
- Dominant language
- Shell
- Stars
- 154
- Forks
- 125
- PR merge metrics
- No merged PRs in 30d
Description
Hi @janeczku,
Thank you for creating this docker image.
One thing I found with a larger dropbox installation, is that when you go through the run file where you do the chown https://github.com/janeczku/docker-dropbox/blob/master/run#L28, it can take a long time to re-do this process, especially depending on the amount of files in your dropbox.
A solution would be to create a conditional statement to see if they are already set, before doing this process. ie $(stat -c "%u" /dbox) Also noticed that this pull request might do the same thing https://github.com/janeczku/docker-dropbox/pull/13/commits/ea15ed11a892ce35710f7b349886be85a636697c
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in the run file around line 28, where the chown operation is performed, and compare it with the referenced pull request commit. Done means the ownership update is skipped when /dbox already has the current user and group IDs, while still running when they differ.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- docker, shell
- Domain
- devops
- Issue type
- Feature
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100