jamulussoftware / jamulussoftware/jamulus
GetValFromStream uses ASSERT which is likely compiled out during release builds
- Dominant language
- C
- Stars
- 1.1k
- Forks
- 248
- Avg merge
- 2d 3h
- Merged PRs (30d)
- 9
Description
https://github.com/jamulussoftware/jamulus/blob/0db554413e6311c00c81900e8af114e1527ab6a7/src/protocol.cpp#L2832-L2833
uses Q_ASSERT but they don't do anything (https://doc.qt.io/qt-6/qtassert.html) in release mode. We should check weather an if () statement isn't better suited.
I assume we need to crash in case of an invalid value?
Contributor guide
Research direction
Inspect src/protocol.cpp at lines 2832-2833 and read the surrounding GetValFromStream logic, then verify what should happen for an invalid value in both debug and release builds. The change is done when invalid input has the intended behavior without relying on an assertion that disappears in release mode.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- networking
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 48/100