jamulussoftware / jamulussoftware/jamulus
Use Consistent Qt style for ifdef
Open
refactoring
- Dominant language
- C
- Stars
- 1.1k
- Forks
- 248
- Avg merge
- 2d 3h
- Merged PRs (30d)
- 9
Description
Are the Windows and Android ones okay? Is the `Q_` a "Qt" thing that we can use for all platforms? What's the `OT_` thing?
_Originally posted by @pljones in https://github.com/jamulussoftware/jamulus/pull/3360#discussion_r1770578872_
The code should be refactored such that only one style is used. Probably Q_OS_WIN: https://doc.qt.io/qt-5/qtglobal.html#Q_OS_WIN
Contributor guide
Research direction
Search the repository for the Q_ and OT_ platform conditionals, then compare the Windows and Android cases with the linked Qt Q_OS_WIN documentation. Done means the relevant platform guards consistently use one style and the existing platform behavior remains unchanged.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- c
- Domain
- operating-systems
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100