jamulussoftware / jamulussoftware/jamulus

Client does not update window on server name change

Open
#3,177 11 comments 0 reactions 1 assignee Claimed by @pljones View on GitHub
bug
Dominant language
C
Stars
1.1k
Forks
248
Avg merge
2d 3h
Merged PRs (30d)
9

Description

**Describe the bug**

If a server is restarted, changing the configuration to have a new server name, if it had been recording before the change, the client - still connected - does not update the recording banner.

**To Reproduce**

1. Start a server named "Server A" on the command line, with recording enabled, activate recording.
2. The red recording banner appears indicating recording is taking place at "Server A".
3. The window title says "Server A".
4. Restart the server with the name "Server B" on the command line.

**Expected behavior**

1. The red recording banner should say "Server B".
2. The window title should say "Server B"

**Screenshots**

Original server started:
```
Jamulus 2059 1 0 Sep20 ? 00:00:09 /opt/Jamulus/bin/Jamulus-server -n -s -p 54850 -T -F -P -u 50 -l /opt/Jamulus/log/Jamulus.log -e anygenre2.jamulus.io:22224 --serverpublicip 192.168.1.19 -R /opt/Jamulus/run/recording -o jamulus.drealm.info;London;224 -w /opt/Jamulus/systemd/welcome-server.html
```
**`-o jamulus.drealm.info;London;224`** -> "jamulus.drealm.info"

Initial server connection:
![image](https://github.com/jamulussoftware/jamulus/assets/1549463/adab8e00-66e9-4773-afdf-9ff2d45ad35b)
Window title and recording banner on initial connection:
![image](https://github.com/jamulussoftware/jamulus/assets/1549463/2566d8ad-759f-41ee-aa84-73110c684525)

Original server stopped and replaced on same port:
```
Jamulus 8281 1 7 18:06 ? 00:00:06 /opt/Jamulus/bin/Jamulus-original-music -n -s -p 54850 -T -F -P -u 10 -l /opt/Jamulus/log/Jamulus.log -e jamulusdirectory8.drealm.info:22824 --serverpublicip 81.174.155.168 -R /opt/Jamulus/run/recording --norecord -o Original Music;London;224 -w /opt/Jamulus/systemd/welcome-original-music.html
```
**`-o Original Music;London;224`** -> "Original Music"

Connection window shows new name (and the welcome message was shown) but recording banner and window title are not updated:
![image](https://github.com/jamulussoftware/jamulus/assets/1549463/4d5bdbd0-2572-49f1-a901-12b9aee1d449)

**Version of Jamulus**

**Client:** 3.10.0
**Server:** 3.10.0

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.