jamulussoftware / jamulussoftware/jamulus

Build: Version comes from git tag, ChangeLog, Jamulus.pro

Open
#2,662 5 comments 0 reactions 0 assignees View on GitHub
bug tooling
Dominant language
C
Stars
1.1k
Forks
248
Avg merge
2d 3h
Merged PRs (30d)
9

Description

> My concern is `get_build_version()` uses a different value. The tag, `Jamulus.pro` and `ChangeLog` could all have different versions.

> Given we have three sources for the version, we really need automation to make sure they're aligned, at least: i.e. error out if things look wrong. But I agree, that's not in scope here. For that, it sounds like (and I don't fully understand how this works):
> * If the tag is set, we should use that to determine build type and version and that source should overrule others.
> * ChangeLog and Jamulus.pro "target" versions should match - and, if set, match the tag build type and version.
> * If the tag wasn't set, build type and version can then come from ChangeLog and Jamulus.pro, as needed.

_Originally posted by @pljones in https://github.com/jamulussoftware/jamulus/pull/2656#discussion_r901061485_

Contributor guide

Open the contributing guide

Research direction

Start by tracing get_build_version() and comparing its behavior with the version declarations in Jamulus.pro and ChangeLog. Inspect how git tags determine build type and version. Done means the version sources are aligned or mismatches are detected, including the tag and no-tag cases described in the issue.

Written by the indexing model from the issue text.

Assessment

Tech stack
c
Domain
build-system, release
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Quiet
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.