jamulussoftware / jamulussoftware/jamulus

Memory leak when using Rpc server

Open
#2,614 11 comments 0 reactions 0 assignees View on GitHub
bug
Dominant language
C
Stars
1.1k
Forks
248
Avg merge
2d 3h
Merged PRs (30d)
9

Description

**Describe the bug**
CServerRpc and CClientRpc/CServerRpc are created with "new" in main.cpp, but are never deleted.

**To Reproduce**
Run Jamulus with and without valid --jsonrpcport and --jsonrpcsecretfile parameters.
Use Visual studio's memory usage diagnostic tool to check the difference in memory usage at exit.

**Expected behavior**
Cleanup on exit.

**Screenshots**

**Operating system**
n.a.

**Version of Jamulus**
master @ 953f2b8a1ccab70d715a54cc730e05059ae140d6

**Additional context**

Contributor guide

Open the contributing guide

Research direction

Start in main.cpp and inspect the CServerRpc and CClientRpc allocations made with new, then run Jamulus with and without valid --jsonrpcport and --jsonrpcsecretfile parameters. Use Visual Studio's memory usage diagnostic tool to compare exit behavior; done means the RPC objects are cleaned up on exit without introducing regressions.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
api, networking
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
58/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.