jamulussoftware / jamulussoftware/jamulus

Flags: Update outdated flags (tv and tk) and add new ones

Open
#2,439 4 comments 0 reactions 0 assignees View on GitHub
bug
Dominant language
C
Stars
1.1k
Forks
248
Avg merge
2d 3h
Merged PRs (30d)
9

Description

In https://github.com/jamulussoftware/jamulus/pull/2409#issuecomment-1053559073 we've added support for previously unsupported territories. This is a follow-up to update the flags:
- [ ] The newly supported `tv` and `tk` flags are historical versions which no longer match the current flag of those countries as per https://en.wikipedia.org/wiki/Country_code_top-level_domain
- [ ] All existing flags should probably be checked for necessary updates (#2409 only checked the 53 newly added flags)
- [ ] Qt support some territories which we do not have flags for. Some probably don't make sense in our usage (World, Europe), but others might be worth adding:

```
8 Antarctica
29 Bouvet Island
75 Guernsey
78 French Southern Territories
95 Heard And McDonald Islands
152 Cura Sao
196 South Georgia And The South Sandwich Islands
238 Canary Islands
241 Clipperton Island
244 Saint Barthelemy
245 Saint Martin
246 Latin America
247 Ascension Island
249 Diego Garcia
250 Ceuta And Melilla
251 Isle Of Man
252 Jersey
253 Tristan Da Cunha
254 South Sudan
255 Bonaire
256 Sint Maarten
257 Kosovo
258 European Union
259 Outlying Oceania
260 World
261 Europe
```

**Describe the solution you'd like**

The outdated flags should be replaced by newer versions.
The original author of the flags which are used in Jamulus (https://famfamfam.com) does not provide newer versions of `tk` and `tv`.

**Describe alternatives that have been considered**

Keep flags outdated, don't add new ones.

Note: I think this is a really low-prio issue for now. I'm not adding a milestone therefore.
cc @jamulussoftware/designers

Contributor guide

Open the contributing guide

Research direction

Start by reviewing the flag changes from pull request #2409 and compare the current tv and tk images with the current country flags referenced from Wikipedia. Then audit the existing flags and Qt's territory list to identify missing additions, using famfamfam's assets where available. Done means outdated flags are replaced and any worthwhile missing territories are added or explicitly excluded.

Written by the indexing model from the issue text.

Assessment

Domain
design
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.