jamulussoftware / jamulussoftware/jamulus

Code: Introduce pClient->setChannelName() and make GUI and JSON-RPC use it

Open
#2,438 5 comments 0 reactions 0 assignees View on GitHub
JSON-RPC refactoring
Dominant language
C
Stars
1.1k
Forks
248
Avg merge
2d 3h
Merged PRs (30d)
9

Description

*(Initially raised by @pljones and @ann0see in https://github.com/jamulussoftware/jamulus/pull/1975/files#r808416974)*

**Has this feature been discussed and generally agreed?**

Yes.

**Describe the solution you'd like**

https://github.com/jamulussoftware/jamulus/blob/master/src/clientsettingsdlg.cpp#L1082-L1098 + clientrpc.cpp should be refactored to use a new `pClient->setChannelName` method.

**Describe alternatives that have been considered**

Live with the duplication.

Contributor guide

Open the contributing guide

Research direction

Start with the referenced lines in src/clientsettingsdlg.cpp and the related code in clientrpc.cpp, then compare how each currently handles the channel name. Refactor both paths to use the new pClient->setChannelName method; done means the GUI and JSON-RPC no longer duplicate that logic while retaining their existing behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
c
Domain
api, audio-video-rtc, desktop
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
62/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.