jamulussoftware / jamulussoftware/jamulus

windows/sound.cpp: Rename CheckDeviceCapabilities()

Open
#1,409 9 comments 2 reactions 0 assignees View on GitHub
good first issue refactoring
Dominant language
C
Stars
1.1k
Forks
248
Avg merge
2d 3h
Merged PRs (30d)
9

Description

**Describe the bug**
`CheckDeviceCapabilities()` in `windows/sound.cpp` does more than what the name suggests: It has side effects such as updating instance variables such as `lNumInChan`.

**Expected behavior**

Have a name which makes it clear that updates happen.

**Version of Jamulus**
d5d4691221b76bc648d605dac867aeaa561d0a52

cc @ann0see @pljones

Contributor guide

Open the contributing guide

Research direction

Start in windows/sound.cpp by reading CheckDeviceCapabilities() and searching for its call sites and references. Choose a name that reflects its updates to instance state, rename the function consistently, and verify that no references to the old name remain.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
audio-video-rtc
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
55/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.