jamesplease / jamesplease/backbone.premium-router
Async err-thang
- Dominant language
- JavaScript
- Stars
- 7
- Forks
- 2
- PR merge metrics
- No merged PRs in 30d
Description
Every callback should be asynchronous.
The code may look something like:
``` js
Promise.resolve(newRoute.beforeFetch(routeData))
.then(Promise.resolve(newRoute.fetch(routeData))
.then(Promise.resolve(newRoute.afterFetch(routeData))
.then( /* current logic */ )
```
Whether or not there should be asynchronous exits for routes will depend on how I want animated exits to work.
Contributor guide
No contributing guide indexed for this repository
Research direction
Start by locating the route callback flow involving beforeFetch, fetch, and afterFetch, then inspect how the current logic handles these callbacks. Determine the intended asynchronous sequencing and whether route exits are included, since the issue leaves animated exits unresolved. Done means the callback behavior and exit scope are defined and implemented consistently.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- frontend
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100