jamalex / jamalex/notion-py

Shouldn't this be `_type`?

Open
#97 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
4.4k
Forks
470
PR merge metrics
No merged PRs in 30d

Description

https://github.com/jamalex/notion-py/blob/56b7a904474619cf60c4768db435c921ca18f44f/notion/block.py#L185

```python
def get_browseable_url(self):
>> if "page" in self._type:
# [pylint E1101] [E] Instance of 'Block' has no '_type' member; maybe 'type'?
```

Also https://github.com/jamalex/notion-py/blob/master/notion/block.py#L475

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Inspect notion/block.py at the referenced lines around get_browseable_url and line 475, then compare the attributes defined and used on Block. Confirm which attribute name is intended and check that the pylint warning is resolved without breaking browseable URL behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
api
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.