jam1garner / jam1garner/binrw

BinWrite requires writer to be Sized

Open
#104 3 comments 0 reactions 1 assignee View on GitHub

@csnover is already working on this.

Since Aug 19, 2022.

Dominant language
Rust
Stars
853
Forks
56
PR merge metrics
No merged PRs in 30d

Description

There doesn't seem to be any good reason for writer to be sized, since it's just a mutable reference. Without `?Sized`, it's impossible to use trait objects with BinWrite.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.