jakob / jakob/Postico

Should "Comment Line" command select the line?

Open
#735 0 comments 1 reaction 0 assignees View on GitHub
Dominant language
Python
Stars
485
Forks
8
PR merge metrics
No merged PRs in 30d

Description

Suppose you have a query like this:

```sql
SELECT
a
, b
, c
FROM
my_table
```

This would allow you to quickly add / remove columns from the output by using the "comment line" command.

However, that command selects the current line. So when you comment the line, and then press cmd-return to execute the query, you end up executing only the comment, which does nothing.

Maybe the "comment line" command should not change the selection?

Or maybe we should remove the "Execute selection" command?

Contributor guide

No contributing guide indexed for this repository

Research direction

Start by reproducing the interaction between the "Comment Line" command and cmd-return in the query editor using the SQL example. Compare whether preserving the selection or changing "Execute selection" best matches the intended workflow; done requires an agreed behavior and verification that commenting a line does not cause an unintended comment-only execution.

Written by the indexing model from the issue text.

Assessment

Tech stack
sql
Domain
databases, desktop
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.