jakiestfu / jakiestfu/Snap.js

google map

Open
#77 2 comments 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
5.9k
Forks
642
PR merge metrics
No merged PRs in 30d

Description

Hi,

I just experienced a very strange issue. I have a google map with some marker. Now if somebody click's on a marker

google.maps.event.addListener(k2, 'click', onMarkerClick);

I trigger: snapper.open('left');

For some reason, the easeTo method (line 196 in snap.js) is called twice.

The call must come from the "endDrag" method, so I've extend the if-statement on line 428 as follow

from

if (cache.isDragging) {

to

if (cache.isDragging && settings.touchToDrag) {

I think this can get implemented in general because the "dragging" function on line 320 does the same.

Best,
Thomas

Contributor guide

No contributing guide indexed for this repository

Research direction

Start in snap.js at easeTo around line 196, then inspect the dragging function near line 320 and endDrag near line 428. Reproduce the Google Maps marker click that opens the shelf with touchToDrag disabled, and verify that easeTo is triggered only once after the relevant guard is corrected.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
frontend
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.