jakiestfu / jakiestfu/Snap.js

IE10 touch taptoclose does not work

Open
#41 5 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
5.9k
Forks
642
PR merge metrics
No merged PRs in 30d

Description

I found a minor issue with the latest IE fix commit.
Tap to close works fine using a real mouse or pen but it does not work with the touch event in IE10 (it was working before the commit). However overall great improvement for IE<10.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the tap-to-close behavior with an IE10 touch event and compare it with mouse or pen input. Inspect the latest IE fix commit and the touch close path; done means tapping to close works in IE10 without regressing mouse or pen behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
mobile-dev
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.