jakartaee / jakartaee/persistence

return types in CriteriaBuilder

Open
#1,004 1 comment 0 reactions 0 assignees Claimed by @gavinking View on GitHub
candidate-for-4
Dominant language
Java
Stars
268
Forks
78
Avg merge
1d 6h
Merged PRs (30d)
13

Description

It would be nice if operations of `CriteriaBuilder` returned `NumericExpression`, `TextExpression`, `TemporalExpression` where appropriate.

A problem is that we have operations like this:

```java
Expression sum(Expression x);
```

and I would have to add an additional type constraint:

```java
> NumericExpression sum(Expression x);
```

That's in principle a backward incompatible change ... but I can't actually see it breaking real code, so perhaps it's OK?

Contributor guide

Open the contributing guide

Research direction

Review the CriteriaBuilder method signatures shown in the issue and the open linked pull request #1005 first. Done means the intended NumericExpression, TextExpression, and TemporalExpression return types are defined consistently and the backward-compatibility concern is resolved.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
api, database
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.