jakartaee / jakartaee/faces

Injectable-artifacts table omits ViewHandler and ELResolver

Open Beginner friendly
#2,180 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Java
Stars
127
Forks
59
Avg merge
23h
Merged PRs (30d)
7

Description

Found while resurrecting TCK tests lost during Mojarra 3.0→4.0 transition — specifically `Spec763IT`, the resurrection of #763 ("classes loaded from faces-config.xml are injectable").

The table *[Jakarta Faces Artifacts Eligible for Injection](https://jakarta.ee/specifications/faces/4.1/jakarta-faces-4.1#jakarta-faces-managed-classes-and-jakarta-ee-annotations)* in `ExpressionLanguageFacility.adoc` (§ *Jakarta Faces Managed Classes and Jakarta EE Annotations*) omits two artifacts that are injectable in practice:

- `jakarta.faces.application.ViewHandler`
- `jakarta.el.ELResolver`

Both were injectable in JSR-314 and Mojarra still injects them today: `ApplicationConfigProcessor.setViewHandler(...)` and `addELResolver(...)` create the instance with `performInjection=true` and register it for `@PreDestroy`. Original support landed in javaee/mojarra:

- https://github.com/javaee/mojarra/commit/7a6f863c80c8e9889c56238e809de8cbe9c83045 — *Make it so classes loaded from the faces-config.xml are injectable*
- https://github.com/javaee/mojarra/commit/5bc213ecc7cff571d06219ca192d719c350771dd — *Verify that ViewHandler, StateManager, SystemEventListener, NavigationHandler, ELResolver, ActionListener and ResourceHandler are injectable*

The omission looks like an oversight in the Faces 4.0 DocBook→asciidoc conversion (d7fc1801d): the table still lists the now heavily `@Deprecated(forRemoval=true)` `StateManager` while dropping the fully-active `ViewHandler`.

Request: re-add `ViewHandler` (and clarify/confirm `ELResolver`) in the eligible-for-injection table.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Open ExpressionLanguageFacility.adoc and find the “Jakarta Faces Artifacts Eligible for Injection” table in the “Jakarta Faces Managed Classes and Jakarta EE Annotations” section. Check the Spec763IT context and the documented injection behavior, then update the table to include ViewHandler and clarify or confirm ELResolver; the table should accurately reflect the injectable artifacts.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
documentation
Issue type
Documentation
Difficulty
1/5
Estimated time
1-3 hours
Activity status
Quiet
Clarity
Clearly specified
Newbie friendliness
72/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.