jagrosh / jagrosh/MusicBot

[Bug Report] Lyrics cannot be found or poorly displayed

Open
#1,204 2 comments 0 reactions 0 assignees View on GitHub
bug
Dominant language
Java
Stars
5.8k
Forks
2.8k
PR merge metrics
No merged PRs in 30d

Description

### Bug Description

Searching for lyrics is very finicky. I hardly ever get results. For example, when searching for `Legends Never Die` I always get `🚫 Lyrics for legends never die could not be found!`

### Steps to Reproduce

1. Set lyrics providers to "A-Z Lyrics". (or any of the others)
2. Search for "legends never die" (https://www.azlyrics.com/lyrics/againstthecurrent/legendsneverdie.html)
3. No lyrics found.

### Expected Result

I expected the lyrics to be displayed, or a list of results from which to select which lyrics to be displayed.

### Debug Output

System Properties:
java.version = 11.0.14.1
java.vm.name = OpenJDK 64-Bit Server VM
java.vm.specification.version = 11
java.runtime.name = OpenJDK Runtime Environment
java.runtime.version = 11.0.14.1+1
java.specification.version = 11
os.arch = amd64
os.name = Linux

JMusicBot Information:
Version = 0.3.8
Owner = 165720973574668288
Prefix = ?
AltPrefix = ?help
MaxSeconds = 0
NPImages = false
SongInStatus = true
StayInChannel = true
UseEval = false
UpdateAlerts = true

Dependency Information:
JDA Version = 4.4.0_352
JDA-Utilities Version = 3.0.5
Lavaplayer Version = 1.3.78

Runtime Information:
Total Memory = 1012
Used Memory = 33

Discord Information:
ID = 913615852706861106
Guilds = 2
Users = 4

### Additional Info

A-Z Lyrics:
https://search.azlyrics.com/search.php?q=legends%20never%20die gives me a page with a search text box, rather than search results. I have to click on search again to get the search results. Could this be the probelm on A-Z Lyrics?

Genius:
https://genius.com/api/search?q=legends%20never%20die actually gives a json with results, and the first result is the desired hit. But no lyrics are actually returned by the bot.

Musicmatch
https://www.musixmatch.com/search/legends%20never%20die returns a result, and the bot also returns the lyrics, but the words are all appended without paragraphs making it difficult to read
![image](https://user-images.githubusercontent.com/13521047/187109057-db1c543d-5f7d-4fa2-8bc0-4ef91439d1c6.png)
So is musicmatch working? Let's try another search for `Somewhere Over The Rainbow` (https://www.musixmatch.com/lyrics/Israel-Kamakawiwo%CA%BBole/Somewhere-Over-The-Rainbow)
https://www.musixmatch.com/search/somewhere%20over%20the%20rainbow shows results, but the lyrics bot returns no lyrics.

LyricsFreak
The bot returns the wrong set of lyrics from LyricsFreak, but that is because the site does not have the desired result. So the bot is working fine at least.

### Checklist

- [X] I have looked for information about this [within the documentation](https://jmusicbot.com/)
- [X] I have searched for similar issues [on the issues page](https://github.com/jagrosh/MusicBot/issues?q=is%3Aissue)
- [X] I am running the latest version of the bot: ![Release](https://img.shields.io/github/release/jagrosh/MusicBot.svg)

Contributor guide

No contributing guide indexed for this repository

Research direction

No source file or test is named. Start by locating the lyrics-provider implementations and reproducing the reported searches for A-Z Lyrics, Genius, and Musixmatch; done means valid lyrics are found where available and Musixmatch results preserve readable paragraph formatting.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
backend
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.