droid target must be first target
Open
Nobody has claimed this yet.
auto-migrated
Priority-Medium
Type-Defect
- Dominant language
- No language data
- Stars
- 0
- Forks
- 0
- PR merge metrics
- No merged PRs in 30d
Description
The rowboat build is violating the intention of the Android makefile system by
copying the build/core/root.mk file to Makefile since this Makefile does not
list droid as the first target.
This make the rest of the makefile system hard to deal with since the whole
AOSP makefile structure relies upon droid to be the first target.
Please see the comment on build/core/main.mk .....
-------------------------------------
# This is the default target. It must be the first declared target.
.PHONY: droid
DEFAULT_GOAL := droid
$(DEFAULT_GOAL):
-------------------------------------
I have attached a patch file that puts droid as the first target.
Original issue reported on code.google.com by andrewva...@gmail.com on 14 Jun 2013 at 3:37
Attachments:
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading build/core/main.mk and comparing the copied Makefile with build/core/root.mk. Review the attached patch for the intended target ordering; done means the Makefile lists droid as its first target and preserves the Android makefile behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- android
- Domain
- build-system
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 35/100