jadonk / jadonk/beagle

Multiple compiler warnings

Open
#2 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

auto-migrated Priority-Medium Type-Defect
Dominant language
C++
Stars
0
Forks
0
PR merge metrics
No merged PRs in 30d

Description

```
There is a lot of minor warnings when compiling using Clang. Especially
assignments in ifs which are not inside of additional parenthesis like

if(lPos = lFinder.findNext()) ===> if(( lPos = lFinder.findNext() ))

and so on. I have fixed all there warnings (including one error described in
Issue #1). See attached diff file and consider merging changes to main
repository.

What steps will reproduce the problem?
1.
2.
3.

What is the expected output? What do you see instead?

What version of the product are you using? On what operating system?

Please provide any additional information below.

```

Original issue reported on code.google.com by `Tomas789@gmail.com` on 3 Dec 2013 at 12:36

Attachments:
- [beagle.diff](https://storage.googleapis.com/google-code-attachments/beagle/issue-2/comment-0/beagle.diff)

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Review the attached beagle.diff and reproduce the project’s Clang compilation to identify the reported warnings, including the error referenced in Issue #1. Done means the proposed warning fixes are applied and the project builds without these warnings.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
compilers
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.