Struct migrations insert #:extra-constructor-name unnecessarily

Open
#47 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
5/5
Estimated time
Over a week
Newbie friendliness
35/100
Issue type
Refactor
Clarity
Mostly clear
Activity status
Stale
Domain
tooling

Research direction

The issue provides no repository file or test entry point; begin by reading racket/scribble#295 and tracing the refactoring rule API and source code analysis phase. Done means struct migrations no longer insert #:extra-constructor-name when all make- constructors can be rewritten.

Written by the indexing model from the issue text.

Description

bug existing lint

See racket/scribble#295 for context. Fixing this is tricky, because it requires knowing that all uses of the make- constructor can be rewritten. This requires first making a pass over the module to look for define-struct forms, then making a pass to look for usages of their constructors, then finally making a third pass to look for define-struct forms whose constructors can all be rewritten. This would require significantly reworking the refactoring rule API and the implementation of the source code analysis phase. It seems like it would enable producing far more useful suggestions, so it's worth exploring.

Dominant language
Racket
Stars
70
Forks
11
No merged PRs in 30d

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from jackfirth/resyntax

All issues in jackfirth/resyntax

Similar issues

More DevTools issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.