jackc / jackc/tod

Support time_select without seconds

Open
#83 0 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Ruby
Stars
447
Forks
56
PR merge metrics
No merged PRs in 30d

Description

Would be nice to support:
```ruby
f.time_select :start_time, include_date: false
```

this will fail converting nil to an integer because `time_of_day_type.rb:7` assumes hour, min and second.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at time_of_day_type.rb:7 and reproduce the failure with time_select :start_time, include_date: false. The issue is done when this usage no longer fails while converting the missing seconds value to an integer.

Written by the indexing model from the issue text.

Assessment

Tech stack
ruby
Domain
backend
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.