jacebrowning / jacebrowning/memegen
Sanic 'request.url' can be invalid
Open
Nobody has claimed this yet.
bug
help wanted
- Dominant language
- Python
- Stars
- 1.7k
- Forks
- 251
- Avg merge
- 6h 20m
- Merged PRs (30d)
- 6
Description
See the workaround added here: https://github.com/jacebrowning/memegen/pull/798/files
I believe this is caused by SERVER_NAME being a URL rather than just hostname, but without that the Swagger UI fails to load in production.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with app/config.py at the SERVER_NAME setting, then compare the workaround linked from memegen pull request 798. Reproduce the production configuration and inspect how Sanic builds request.url while loading Swagger UI. Done means request.url is valid and the production Swagger UI still loads.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- api
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100