jaames / jaames/iro.js

Wrong TS declaration of id at ColorPickerProps

Open
#251 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
1.5k
Forks
91
PR merge metrics
No merged PRs in 30d

Description

Hey, I had some starting issues to setup the ts properly using your library.
In the end this was the last puzzle piece and I thing the type of the id inside ColorPickerProps shouldn't be null instead it should be a string?

```
export interface ColorPickerProps extends IroColorPickerOptions {
display?: string;
id?: null; <<<---- shouldn't this be a string?
layout?: ColorPickerLayoutDefinition[] | ColorPickerLayoutShorthand;
colors?: IroColorValue[];
transparency?: boolean;
margin: number;
}
```

Contributor guide

Open the contributing guide

Research direction

Search the TypeScript declaration for the ColorPickerProps interface shown in the issue and inspect how its id property is used. Verify the declaration with the project's available type or build checks; done means id is optional and accepts string values rather than only null.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
frontend
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.