jaames / jaames/flipnote.js

PPM filename check-digit calculation may not be correct

Open
#39 0 comments 0 reactions 0 assignees View on GitHub
bug good first issue help wanted
Dominant language
TypeScript
Stars
79
Forks
5
PR merge metrics
No merged PRs in 30d

Description

https://github.com/jaames/flipnote.js/blob/083ca4ef9e42f09dde03550da4dd1670110a1359/src/parsers/filename/ppm.ts#L36

Seems to work on some samples, but not on others. Wonder if it uses the current console MAC suffix, and not the one from the original filename?

Contributor guide

No contributing guide indexed for this repository

Research direction

Start with src/parsers/filename/ppm.ts at line 36 and compare filename samples where the check digit works with those where it does not. Investigate whether the calculation uses the current console MAC suffix or the suffix from the original filename. Done means the calculation is correct across the reported samples.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
data
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.