jMonkeyEngine / jMonkeyEngine/jmonkeyengine
excessive calls to glObjectLabel etc
- Dominant language
- Java
- Stars
- 4.3k
- Forks
- 1.2k
- Avg merge
- 4d 7h
- Merged PRs (30d)
- 14
Description
glObjectLabel is being called for every update in setVertexAttrib instead of just once right after creation:
https://github.com/jMonkeyEngine/jmonkeyengine/blob/03c26a8a253395bbd2736784cd4cb1c6dd102270/jme3-core/src/main/java/com/jme3/renderer/opengl/GLRenderer.java#L3220
This actually shows up in RenderDoc and in a CPU usage profile.
Also vb.getName() never returns null.
Also if not done right after creation it's easy to miss something, e.g. index buffers are never set cause of
https://github.com/jMonkeyEngine/jmonkeyengine/blob/03c26a8a253395bbd2736784cd4cb1c6dd102270/jme3-core/src/main/java/com/jme3/renderer/opengl/GLRenderer.java#L3116-L3118
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.