jMonkeyEngine / jMonkeyEngine/jmonkeyengine
jme3-plugins loads MorphPrimitivesTest incorrectly
Nobody has claimed this yet.
- Dominant language
- Java
- Stars
- 4.3k
- Forks
- 1.2k
- Avg merge
- 4d 7h
- Merged PRs (30d)
- 14
Description
I noticed a defect in GltfLoader while developing the MonkeyWrench library.
The test data is MorphPrimitivesTest from Khronos's glTF sample models.
Here's how it looks in CompareLoaders when "MorphPrimitivesTest/glTF/MorphPrimitivesTest.gltf" is loaded using jme3-plugins:
I believe the best approach to solve this issue will be:
- Add a
MorphControlto every model with morph targets, even if there are no animation tracks. - Initialize the morph state of each
Geometryby invokingsetMorphState()with the "weights" values in the glTF.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in GltfLoader and reproduce the issue by loading MorphPrimitivesTest/glTF/MorphPrimitivesTest.gltf through jme3-plugins, comparing the result with CompareLoaders. Trace how morph targets and the glTF weights are handled, then verify that models with morph targets receive the expected morph state even without animation tracks.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java
- Domain
- computer-graphics, game-dev
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100