jMonkeyEngine / jMonkeyEngine/jmonkeyengine
Sphere.TextureMode.Polar is highly misleading
Nobody has claimed this yet.
- Dominant language
- Java
- Stars
- 4.3k
- Forks
- 1.2k
- Avg merge
- 4d 7h
- Merged PRs (30d)
- 14
Description
I've been debugging the coordinate values that TextureMode.Polar creates for a longer time now and I've also looked into the code. I've come to the conclusion that the coordinates, that TextureMode.Polar creates, are not polar at all, but some sort of Cartesian?!
Please take into account what is commonly understood under polar coordinates.
I've already asked on the forums, where I've been told that TextureMode.Polar in fact projects the texture to the poles of the sphere. Regarding this, maybe TextureMode.PolarProjected would be a more appropriate term for what is currently implemented as TextureMode.Polar.
I think that TextureMode.Original actually creates polar coordinates. Please consider renaming TextureMode.Original to TextureMode.Polar, since this would be more self-descriptive.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the Sphere texture-generation code and the TextureMode.Polar and TextureMode.Original entry points, then review the linked forum discussion and the polar-coordinate reference. Trace usages of the enum names before deciding whether PolarProjected and Polar should be renamed. Done means the naming accurately describes the coordinate mappings and all affected API references are consistent.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java
- Domain
- computer-graphics, game-dev
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100