jMonkeyEngine / jMonkeyEngine/jmonkeyengine
Restrict the blend weight values to the range [0, 1]
Nobody has claimed this yet.
- Dominant language
- Java
- Stars
- 4.3k
- Forks
- 1.2k
- Avg merge
- 4d 7h
- Merged PRs (30d)
- 14
Description
According to the discussion on PR #2022, @Ali-RS suggests it would be better to restrict the input to the range 0 to 1 only by throwing an IllegalArgumentException with a message denoting an out-of-range number to avoid extrapolation and unexpected behaviors of negative numbers, the same as BlendableAction#setMaxTransitionWeight(double).
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reviewing the discussion in PR #2022 and comparing the requested behavior with BlendableAction#setMaxTransitionWeight(double). Locate the blend-weight input or setter, then verify that values from 0 through 1 remain accepted and out-of-range values throw IllegalArgumentException with a message identifying the number; no test file is named in the issue.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java
- Domain
- game-dev
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100