jMonkeyEngine / jMonkeyEngine/jmonkeyengine

GraphicsTracing/Timing on non-lwjgl backends

Open
#1,278 1 comment 0 reactions 2 assignees View on GitHub

@MeFisto94 is already working on this.

Since Feb 2, 2020.

Easy first fix Needs investigation
Dominant language
Java
Stars
4.3k
Forks
1.2k
Avg merge
4d 7h
Merged PRs (30d)
14

Description

I think I found two nits to fix in GraphicsTrace:
https://github.com/jMonkeyEngine/jmonkeyengine/blob/acbddc2763117da6cc5d2cd66c63d98a6f31fa44/jme3-android/src/main/java/com/jme3/system/android/OGLESContext.java#L217
This misses GL2.class, which is implemented by https://github.com/jMonkeyEngine/jmonkeyengine/blob/acbddc2763117da6cc5d2cd66c63d98a6f31fa44/jme3-android/src/main/java/com/jme3/renderer/android/AndroidGL.java#L45

And for JOGL:
https://github.com/jMonkeyEngine/jmonkeyengine/blob/acbddc2763117da6cc5d2cd66c63d98a6f31fa44/jme3-jogl/src/main/java/com/jme3/system/jogl/JoglContext.java#L188
and the following address the wrong GL.class here, because GL.class is com.jogamp.opengl.GL, and not the com.jme3.renderer.opengl.GL (aka OpenGL 1 interface).

Both issues probably don't harm beyond instanceof Checks fail, but it could also be that the Proxy doesn't even hook the GL methods in that case, which would make this more critical.

On a similar sidenote: Why is there only GraphicsTrace for Android but no GraphicsTiming, which would also be interesting? Forgotten?

Sorry paul for again taking your time, but you are probably the only one knowing Proxies and I guess for you it's only a matter of 5 minutes then.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.