jMonkeyEngine / jMonkeyEngine/jmonkeyengine

Split Renderer and desired openGL Version

Open
#1,253 0 comments 0 reactions 1 assignee View on GitHub

@MeFisto94 is already working on this.

Since Jan 12, 2020.

Dominant language
Java
Stars
4.3k
Forks
1.2k
Avg merge
4d 7h
Merged PRs (30d)
14

Description

Currently our AppSettings are very static leading to code as you can see in #1252
We need switch statements and other tricks to extract the version number out of the string.

I'll first want to discuss this with you, as I might be overlooking things, but:
Can we say Renderer = LWJGL3, OPENGL_MAJ = 3, OPENGL_MIN = 2 for LWJGL3 OpenGL 3.2?

I know that JOGL falls out of that row, as they don't support a specific version but have FORWARD_[...] etc, but those could then just ignore the OpenGL Version specified and be seperated Renderers as has been already.

Technically every Rendering Backend should want an OpenGL Version at some point, and it would be much better if we had two dedicated integers for it, so we don't have that ugly parsing and also don't have to add it when new versions emerge.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.