jMonkeyEngine / jMonkeyEngine/jmonkeyengine
android.jar should be loaded from the local android sdk installation and not shipped with the engine.
Nobody has claimed this yet.
- Dominant language
- Java
- Stars
- 4.3k
- Forks
- 1.2k
- Avg merge
- 4d 7h
- Merged PRs (30d)
- 14
Description
Also, would it be possible to make the build script download lib/android.jar from an official source?
It would be preferable than uploading a mistery jar to the repo.I agree but a previous file of this one was included this way before and honestly I don't know where I could get this jar directly from the net. Android.jar is extracted to platform path of android sdk when installing it. Maybe adding a copy action to the gradle scripts as the sdk dir is set in the local.properties file?
If this is a dependency, gradle can just load it from the sdk folder. [...]
Originally posted by @riccardobl in https://github.com/jMonkeyEngine/jmonkeyengine/pull/1147#issuecomment-513174014
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by inspecting the Gradle scripts and local.properties, then locate how lib/android.jar is currently included. Check how the local Android SDK path and platform android.jar are exposed to the build. Done means the build uses the local SDK jar without shipping the repository copy, with the relevant build path still working.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- android, java
- Domain
- build-system
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100