jMonkeyEngine / jMonkeyEngine/jmonkeyengine

Particle.j3md glow color ignores color interpolation

Open
#1,030 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Java
Stars
4.3k
Forks
1.2k
Avg merge
4d 7h
Merged PRs (30d)
14

Description

The translucent white texture you input into the particle emitter is blended with the current particle color. However, for the glow color this is not the case. No matter what color the particle currently is, its glow color will always be sampled from the non-blended texture, therefore everything goes white once you enable bloom.
I might have explained a bit badly, so here are two screenshots for illustration:
No bloom:
screenshot from 2019-03-03 19-46-26
Bloom:
screenshot from 2019-03-03 19-46-32
In both cases the set diffuse and glow texture are the same.

I assume Particle.j3md is using the standard glow.frag while it should actually be using a separate shader that also does the blending.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by inspecting Particle.j3md and the glow.frag shader it references, comparing the glow path with the diffuse particle-color blending described in the issue. Confirm the behavior with bloom enabled and verify that the glow color follows the current particle color instead of sampling only the unblended texture.

Written by the indexing model from the issue text.

Assessment

Domain
computer-graphics, game-dev
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.