ivanseidel / ivanseidel/Gaussian

Factor of 2?

Open
#6 3 comments 1 reaction 0 assignees View on GitHub
Dominant language
C++
Stars
53
Forks
11
PR merge metrics
No merged PRs in 30d

Description

Hi - is is possible that this equation should be modified as noted below?

// return mean + variance * cos( 2 * M_PI * R1) * sqrt(-log(R2));
return mean + variance * cos( 2 * M_PI * R1) * sqrt(-2*log(R2));

This appears to be the Box-Muller Transformation, and thus I think there needs to be a 2 inside the sqrt.
thx

Contributor guide

No contributing guide indexed for this repository

Research direction

Locate the Gaussian-generation code containing the displayed return equation and read the surrounding implementation. Verify the formula against the Box–Muller transformation, then run the repository's available tests or examples and confirm the generated values still behave as expected.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
embedded-iot
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.