ivanhercaz / ivanhercaz/CanaryBot

"Removes the duplicates automatically" enter in a loop of actions

Open
#15 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug help wanted PAWS
Dominant language
No language data
Stars
1
Forks
0
PR merge metrics
No merged PRs in 30d

Description

Testing in PAWS the new functionality (#10), when the "Removes the duplicates automatically" is chosen, it enters in a loop of "Updating the log..." and "Description added to the file". Effectively, as it said, the log is updated and the description added each time it appears.

This [gist](https://gist.github.com/ivanhercaz/3a36f5deac12e3106a2a43e39ca2de25) shows three files. The first and the second shows the error commented but in different quantity (the second is longer). And the third file is the "duplicatedFullStopsDesc.csv", the file in which the descriptions have to be saved, and it shows how the identifier and the description is repeated several and different times each time I mark a description with the option mentioned above. This can be checked in the [generated log](https://paws-public.wmflabs.org/paws-public/46785895/CanaryBot/logs/2019-02-02-fullStopsChecker.html) too.

Tasks:
- [ ] Review the structure of the code and discover why it happens.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the three files linked in the gist and trace the action selected by “Removes the duplicates automatically,” comparing its updates with the generated log and duplicatedFullStopsDesc.csv. Done means selecting that option performs one update and writes each identifier and description once, without repeating the action loop.

Written by the indexing model from the issue text.

Assessment

Domain
tooling
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.