ivanhercaz / ivanhercaz/CanaryBot

Avoid the use of global variables

Open
#12 0 comments 0 reactions 0 assignees View on GitHub
minor
Dominant language
No language data
Stars
1
Forks
0
PR merge metrics
No merged PRs in 30d

Description

Minor issue to remember that I should learn a way to avoid the creation of global variables that are going to be modified internally, as:

https://github.com/ivanhercaz/CanaryBot/blob/13ca8bd8fedd441367af41ea5366ce05cfd53840/fullstopschecker.py#L116

Modified in:

https://github.com/ivanhercaz/CanaryBot/blob/13ca8bd8fedd441367af41ea5366ce05cfd53840/fullstopschecker.py#L360-L361

Contributor guide

No contributing guide indexed for this repository

Research direction

Start by inspecting fullstopschecker.py at the referenced lines 116 and 360-361 to understand which global is modified internally. Done means the internal state no longer relies on a modified global variable, while the bot's existing behavior remains unchanged.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
tooling
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.