handling multipacket responses
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 217
- Forks
- 21
- PR merge metrics
- No merged PRs in 30d
Description
Hi, So I think I've fixed RCON in forge for proper multipacket responses that don't overflow..
Sadly, your cli doesn't properly handle them. https://wiki.vg/RCON#Fragmentation discusses how you might go about it...
I'd suggest the third trick, with an invalid packet that you discard afterwards.
https://github.com/MinecraftForge/MinecraftForge/commit/5f292895cb89d42b9a5d12922c80541874e0bf39
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Read the RCON fragmentation guidance at wiki.vg/RCON#Fragmentation and compare it with the linked MinecraftForge commit. Then locate the CLI's response-handling entry point and verify that oversized responses are reconstructed correctly without leaving the suggested invalid packet in the result.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- cli, networking
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100