itzg / itzg/minecraft-server-charts
minecraft: unused deprecated serviceAnnotations property
Nobody has claimed this yet.
- Dominant language
- Mustache
- Stars
- 406
- Forks
- 164
- Avg merge
- 1h 34m
- Merged PRs (30d)
- 1
Description
The `minecraftServer.serviceAnnotations` field present at https://github.com/itzg/minecraft-server-charts/blob/197dcf3bfb2bbe8dae1d78e73e61a3878f2e5658/charts/minecraft/values.yaml#L257-L258 is not being used
We can confuse it with the real `serviceAnnotations` field present in the root level, thus applying no annotations to the service
used at
As of 2024-08-06, the `minecraftServer.serviceAnnotations` [is not used](https://github.com/search?q=repo%3Aitzg%2Fminecraft-server-charts+minecraftServer.serviceAnnotations&type=commits), which means that we can safely remove it
Because it's not worth creating a new release simply to remove a deprecated field, someone can reference this issue in the next release pull request to remove it
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in charts/minecraft/values.yaml at the deprecated minecraftServer.serviceAnnotations field and compare it with the root-level serviceAnnotations referenced by charts/minecraft-bedrock/templates/minecraft-svc.yaml. Confirm the nested field has no uses, then remove it and reference this issue from the next release pull request.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- helm, kubernetes
- Domain
- infrastructure
- Issue type
- Refactor
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 68/100