itzg / itzg/minecraft-server-charts
Change persistence.dataDir.storageClass to persistence.dataDir.storageClassName
- Dominant language
- Mustache
- Stars
- 406
- Forks
- 164
- Avg merge
- 1h 34m
- Merged PRs (30d)
- 1
Description
The documentation in the values.yaml under persistence use the boilerplate text
https://github.com/itzg/minecraft-server-charts/blob/30076e538c67e5c8b256c61aa8c1cb9f57fb4814/charts/minecraft/values.yaml#L271-L285
Which indicates that to use a storageClass you should use storageClassName. This is inline with many other charts and the value in a PVC definition. However the template uses storageClass instead of storageClassName. I didn't find this until I looked at the template itself and the deployment used a local-path instead of my specified storageclass
https://github.com/itzg/minecraft-server-charts/blob/30076e538c67e5c8b256c61aa8c1cb9f57fb4814/charts/minecraft/templates/datadir-pvc.yaml#L26-L30
Either the documentation in README.md and the values.yaml should be updated, or better the general standard should be followed and use storageClassName
Contributor guide
No contributing guide indexed for this repository
Research direction
Start with charts/minecraft/values.yaml lines 271-285 and templates/datadir-pvc.yaml lines 26-30, then check the README references to the same setting. Verify how the chart renders the PVC when a storage class is configured; done means the documented key and rendered PVC behavior agree with the intended storage class.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- helm, kubernetes
- Domain
- devops, infrastructure
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 52/100