itzg / itzg/docker-minecraft-server

Ensure generic pack contents have suitable permissions

Open
#3,206 0 comments 0 reactions 0 assignees View on GitHub
enhancement type/generic-pack
Dominant language
Shell
Stars
14.3k
Forks
1.9k
Avg merge
2d 10h
Merged PRs (30d)
31

Description

I know, but like I mentioned before, my CurseForge API key keeps getting limited and the downloads stop, so that AutoForge isn't working for me.
Thats why I'm using the generic setup. But anyway, we might have found the solution to what was going on. Basically the server-files.zip of ATM 10 has very weird permissions inside (version 2.8 and 2.9). Basically the whole content of the zip in 2.7 is writable and 2.8+2.9 had files that were read only.

So it would be awesome if you could add something like this: when you unzip the server files in your script you `chmod 755` them so any weirdness with permissions being carried over can be prevented, at least if that doesn't cause any security implications.

Otherwise the user has to manually unzip -> change permission -> zip -> copy into the downloads folder again

_Originally posted by @fab0912 in https://github.com/itzg/docker-minecraft-server/discussions/3204#discussioncomment-11652622_

Contributor guide

No contributing guide indexed for this repository

Research direction

The issue does not name a file or test; start by locating the generic setup's server-files.zip extraction path and inspect how permissions are handled. Done means extracted generic pack contents have suitable writable permissions and the affected ATM 10 server files can be used without manually changing and repacking them.

Written by the indexing model from the issue text.

Assessment

Tech stack
docker, shell
Domain
devops, infrastructure
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.