itzg / itzg/docker-minecraft-server

Modernize custom server jar file naming logic

Open
#3,056 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
Shell
Stars
14.3k
Forks
1.9k
Avg merge
2d 10h
Merged PRs (30d)
31

Description

Rather than just derive the custom server jar name from the given URL path it should use mc-image-helper's `get` operation to output to /data directory and derive filename from attachment filename in content disposition header.

Could also accept a CUSTOM_JAR_NAME variable to further customize.

[Asked about in Discord](https://discord.com/channels/660567679458869252/660567682751528981/1281327384846667858)

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

The issue does not name a file or test. Start by locating the custom server URL download and naming logic, then review mc-image-helper's get operation; done means downloading into /data, deriving the filename from the Content-Disposition attachment header, and supporting CUSTOM_JAR_NAME.

Written by the indexing model from the issue text.

Assessment

Tech stack
shell
Domain
devops
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.